Update to NAP 0.8 - #13
Open
CasimirGeelhoed wants to merge 704 commits into
Open
Conversation
…ensures applicaiton works with relevant, active information, including new attached displays etc.
… reporting when sdl video subsystem fails to initialize
…can happen when multiple nap applications are sourced alongside each other in the same host environment
…port it properly yet.
SDL3 Napkin Applet Integration
Member
Author
|
I reimplemented our style settings as a StyleDef in app_structure.json instead of as an additional custom property of ImGUIServiceConfiguration, which means that the napimgui module is (almost) identical again to its upstream counterpart (the only difference now is 3f69131). In naprender, I created a new SetWindowIcon property in RenderServiceConfiguration to be able to disable the default NAP icon. I will include this change in a PR to upstream/nap-0.8. |
CasimirGeelhoed
marked this pull request as ready for review
June 24, 2026 15:26
Member
Author
|
Now also includes a fix for the crash that occurs when resizing the app window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates NAP from stijnvanbeek/nap:nap-0.8.
The following additional changes were made:
To keep our fine-grained definitions of GUI colours, I re-added
imguistylesettings.h&imguistylesettings.cppand included these custom ‘StyleSettings’ as a property of the ImGUIServiceConfiguration.createStyle()was rewritten to apply these settings.To preserve the 4DSOUND icon (as set in Info.plist), I commented out a few lines of code in renderservice.cpp which set the window icon to “naprender/data/nap_icon.png” (hardcoded).
The -E option to add a MacOS Entitlements file was added to package_app.sh.
package_4dsound.sh was rewritten to work with the new package_app.sh script.
I wonder if we should try to keep the 4DSOUND version of system modules in sync with the upstream repo. I could do that by creating separate napimgui and naprender modules for 4DSOUND, or by pushing changes back (adding ServiceConfiguration options for more fine-grained colour overrides and for enabling/disabling/setting the 'window icon' with a custom path).